Bug #63

Warnings in drmaa library and others when compiling

Added by Alejandro Lorca over 2 years ago. Updated about 2 years ago.

Status:Closed Start date:2009-09-25
Priority:Low Due date:
Assignee:Alejandro Lorca % Done:

80%
Category:-
Target version:5.6.0 Estimated time:6.00 hours

Description

In the developing version of GridWay 5.6 there are plenty of warnings for the gw_drmaa

./drmaa/gw_drmaa.c: In function ‘drmaa_init’:
./drmaa/gw_drmaa.c:364: warning: format not a string literal and no format arguments

There are also other warnings in src/em/gw_em_mad.c:

em/gw_em_mad.c: In function ‘gw_em_mad_submit’:
em/gw_em_mad.c:125: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result
...

and for src/tm/gw_tm_mad.c
tm/gw_tm_mad.c: In function ‘gw_tm_mad_mkdir’:
tm/gw_tm_mad.c:81: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result
...

and src/im/gw_im_mad.c
im/gw_im_mad.c: In function ‘gw_im_mad_discover’:
im/gw_im_mad.c:74: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result
...

and src/dm/gw_dm_mad.c:
dm/gw_dm_mad.c: In function ‘gw_dm_mad_schedule’:
dm/gw_dm_mad.c:65: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result
...

Some overflow warnings in src/host/gw_host.c

In function ‘strncat’,
    inlined from ‘gw_host_print’ at host/gw_host.c:445:
/usr/include/bits/string3.h:153: warning: call to __builtin___strncat_chk might overflow destination buffer
...

Associated revisions

Revision 173
Added by Alejandro Lorca over 2 years ago

Major upgrade getting close to version 5.6.0.
Several bug fixing, warnings and features have been worked out.
Check issues #25, #26, #27, #29, #30, #38, #59, #60, #63 for details in http://dev.gridway.org.

Revision 180
Added by Alejandro Lorca over 2 years ago

Documentation removed.
Some warnings concerning issue #63 resolved.
Configure.in with tests for perl and ruby new libraries (check issues #37 and #69).

History

#1
Updated by Alejandro Lorca over 2 years ago

  • Target version set to 5.5.0

#2
Updated by Alejandro Lorca over 2 years ago

  • % Done changed from 10 to 40

Proper snprintf syntax used in src/drmaa/gw_drmaa.c with 4 arguments instead of 3

#3
Updated by Alejandro Lorca over 2 years ago

  • % Done changed from 40 to 60

For the warnings

... ignoring return value of ‘write’, declared with attribute warn_unused_result

it suffices to add a return integer assigned.

#4
Updated by Alejandro Lorca over 2 years ago

  • Status changed from Assigned to Resolved
  • % Done changed from 60 to 90

Other warnings have been worked out, like those coming from overflow in strncat.

#5
Updated by Alejandro Lorca over 2 years ago

  • Status changed from Resolved to Closed
  • % Done changed from 90 to 100

Several part of the code were patched in order to avoid those warnings.
Fix committed.

#6
Updated by Alejandro Lorca over 2 years ago

  • Status changed from Closed to Assigned
  • % Done changed from 100 to 90

Test on the installation on a Ubuntu server shows also a fscanf warning in dummy tm mad.

#7
Updated by Alejandro Lorca over 2 years ago

  • % Done changed from 90 to 80
  • Estimated time changed from 3.00 to 6.00

Alejandro Lorca wrote:

In the developing version of GridWay 5.6 there are plenty of warnings for the gw_drmaa [...]

There are also other warnings in src/em/gw_em_mad.c: [...] and for src/tm/gw_tm_mad.c [...] and src/im/gw_im_mad.c [...] and src/dm/gw_dm_mad.c: [...]

Some overflow warnings in src/host/gw_host.c [...]

More warnings are still appearing and were not described above

host/gw_host_attr_parser.c:1368: warning: ‘input’ defined but not used


common/gw_template_parser.c:1915: warning: ‘input’ defined but not used


job/gw_job_template_var_parser.c:1180: warning: ‘input’ defined but not used


gwd/gw_conf_parser.c:1481: warning: ‘input’ defined but not used


gwd/gw_sch_conf_parser.c:1342: warning: ‘input’ defined but not used

as well as older unused ones in src/tm_mad/gw_tm_dummy.c

#8
Updated by Alejandro Lorca over 2 years ago

  • Status changed from Assigned to Resolved
  • Priority changed from Normal to Low

Warnings in src/tm_mad/gw_tm_dummy.c resolved.
The other, coming from a #ifdef __cplus_plus are left at the moment.

#9
Updated by Alejandro Lorca over 2 years ago

  • Target version changed from 5.5.0 to 5.6.0

#10
Updated by Alejandro Lorca about 2 years ago

  • Status changed from Resolved to Closed

The remaining warnings are not considered to be cleaned up, because they become essential to distinguish the installation in another OS.

Also available in: Atom PDF